| From: | Jeff Davis <pgsql(at)j-davis(dot)com> |
|---|---|
| To: | Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Joe Conway <mail(at)joeconway(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [17] CREATE SUBSCRIPTION ... SERVER |
| Date: | 2024-01-13 01:17:26 |
| Message-ID: | 2a89b14a2b1622bffb8b137ca1f9ab7866f2d2b9.camel@j-davis.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, 2024-01-05 at 16:11 +0530, Ashutosh Bapat wrote:
> I don't think we need to add a test for every FDW. E.g. adding a test
> in file_fdw would be pointless. But postgres_fdw is special. The test
> could further create a foreign table ftab_foo on subscriber
> referencing foo on publisher and then compare the data from foo and
> ftab_foo to make sure that the replication is happening. This will
> serve as a good starting point for replicated tables setup in a
> sharded cluster.
>
Attached updated patch set with added TAP test for postgres_fdw, which
uses a postgres_fdw server as the source for subscription connection
information.
I think 0004 needs a bit more work, so I'm leaving it off for now, but
I'll bring it back in the next patch set.
Regards,
Jeff Davis
| Attachment | Content-Type | Size |
|---|---|---|
| v6-0001-Fix-postgresql_fdw_validator-to-use-full-libpq-op.patch | text/x-patch | 8.5 KB |
| v6-0002-Add-built-in-foreign-data-wrapper-pg_connection_f.patch | text/x-patch | 124.9 KB |
| v6-0003-CREATE-SUSBCRIPTION-.-SERVER.patch | text/x-patch | 47.2 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2024-01-13 02:37:05 | Re: Fix minor memory leak in connection string validation |
| Previous Message | Thomas Munro | 2024-01-13 00:57:54 | Re: cfbot is failing all tests on FreeBSD/Meson builds |