| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump: Remove obsolete trigger support |
| Date: | 2024-01-09 16:29:22 |
| Message-ID: | 2a302b5b-4011-4355-82bf-74e831817125@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 09.01.24 16:27, Tom Lane wrote:
> Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
>> In 30e7c175b81, support for pre-9.2 servers was removed from pg_dump.
>> But I found that a lot of dead code was left for supporting dumping
>> triggers from those old versions, presumably because that code was not
>> behind straightforward versioned "if" branches. This patch removes the
>> rest of the unneeded code.
>
> Hm, you're right, we can depend on pg_get_triggerdef in all cases now.
> However, the patch looks a little incomplete: you did not remove
> fetching of all of the now-unneeded values from the SQL queries.
I think all the remaining SQL queries only select the fields that are
needed. The now-unneeded values were only selected by queries that are
being deleted. If I missed something, an example would help me.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2024-01-09 16:35:34 | Re: Emit fewer vacuum records by reaping removable tuples during pruning |
| Previous Message | Tristan Partin | 2024-01-09 16:27:54 | Re: Make psql ignore trailing semicolons in \sf, \ef, etc |