Re: pg_dump: Remove obsolete trigger support

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(at)eisentraut(dot)org>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump: Remove obsolete trigger support
Date: 2024-01-09 15:27:42
Message-ID: 2184267.1704814062@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(at)eisentraut(dot)org> writes:
> In 30e7c175b81, support for pre-9.2 servers was removed from pg_dump.
> But I found that a lot of dead code was left for supporting dumping
> triggers from those old versions, presumably because that code was not
> behind straightforward versioned "if" branches. This patch removes the
> rest of the unneeded code.

Hm, you're right, we can depend on pg_get_triggerdef in all cases now.
However, the patch looks a little incomplete: you did not remove
fetching of all of the now-unneeded values from the SQL queries.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2024-01-09 15:44:49 Re: the s_lock_stuck on perform_spin_delay
Previous Message Ants Aasma 2024-01-09 15:25:42 Re: add AVX2 support to simd.h