Re: Adding support for SSLKEYLOGFILE in the frontend

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com>, Abhishek Chanda <abhishek(dot)becs(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Adding support for SSLKEYLOGFILE in the frontend
Date: 2025-03-13 22:07:33
Message-ID: 2D123C72-0E49-4AE2-9E55-247AD95BA0DB@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 13 Mar 2025, at 19:31, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>
> Jacob Champion <jacob(dot)champion(at)enterprisedb(dot)com> writes:
>> Adding the PG prefix to the envvar name addresses my collision
>> concern, but I think Tom's comment upthread [1] was saying that we
>> should not provide any envvar at all:
>
>>> I think it might be safer if we only accepted it as a connection
>>> parameter and not via an environment variable.
>
>> Is the addition of the PG prefix enough to address that concern too?
>
> Indeed, I was advocating for *no* environment variable. The PG prefix
> does not comfort me.

Attached is a rebased version which fixes the test failure under autoconf (I
had missed git adding the configure file..) and Windows where the backslashes
weren't escaped properly. It also removes the environment variable and has
documentation touchups.

--
Daniel Gustafsson

Attachment Content-Type Size
v9-0001-libpq-Add-support-for-dumping-SSL-keylog-to-file.patch application/octet-stream 9.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Munro 2025-03-13 22:31:47 Re: md.c vs elog.c vs smgrreleaseall() in barrier
Previous Message David Rowley 2025-03-13 21:52:08 Re: Query ID Calculation Fix for DISTINCT / ORDER BY and LIMIT / OFFSET