| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: automating perl compile time checking |
| Date: | 2018-06-05 21:14:44 |
| Message-ID: | 2A61FFFD-7A7F-483F-82FE-89135D40A863@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 5 Jun 2018, at 16:31, Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> wrote:
> The patch contains a simple script to run the checks. The code that finds perl files is put in a function in a single file that is sourced by the three locations that need it.
+1 on centralizing the find-files function.
> The directory pgperlcritic is renamed to perlcheck, as it not contains the new script as well as pgperlcritic.
This comment should say “perlcheck/..” and not “pgperlcritic/.." I assume:
--- /dev/null
+++ b/src/tools/perlcheck/pgperlcritic
@@ -0,0 +1,20 @@
+#!/bin/sh
+
+# src/tools/pgperlcritic/pgperlcritic
cheers ./daniel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2018-06-05 21:17:31 | Re: automating perl compile time checking |
| Previous Message | Chapman Flack | 2018-06-05 21:11:17 | Re: Why is fncollation in FunctionCallInfoData rather than fmgr_info? |