| From: | Sergei Kornilov <sk(at)zsrv(dot)org> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Masahiko Sawada <masahiko(dot)sawada(at)2ndquadrant(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Álvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Subject: | Re: Improve handling of parameter differences in physical replication |
| Date: | 2020-11-19 19:17:34 |
| Message-ID: | 2985371605808012@mail.yandex.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello
Thank you! I'm on vacation, so I was finally able to review the patch.
Seems WAIT_EVENT_RECOVERY_PAUSE addition was lost during patch simplification.
> ereport(FATAL,
> (errmsg("recovery aborted because of insufficient parameter settings"),
> errhint("You can restart the server after making the necessary configuration changes.")));
I think we should repeat here conflicted param_name and minValue. pg_wal_replay_resume can be called days after recovery being paused. The initial message can be difficult to find.
> errmsg("recovery will be paused")
May be use the same "recovery has paused" as in recoveryPausesHere? It doesn't seem to make any difference since we set pause right after that, but there will be a little less work translators.
Not sure about "If recovery is unpaused". The word "resumed" seems to have been usually used in docs.
regards, Sergei
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2020-11-19 19:31:14 | parsing pg_ident.conf |
| Previous Message | Alvaro Herrera | 2020-11-19 18:15:21 | Re: error_severity of brin work item |