Re: Windows meson build

Vladlen Popolitov писал(а) 2024-12-27 09:57:
> Kohei Harikae (Fujitsu) писал(а) 2024-12-27 04:31:
>> Hi,
>>
>> Thank you for your advice.
>> I added a sample setting PKG_CONFIG_PATH based on your advice.
>>
>> How do you think about this?
>>
>> Regards,
>> Kohei Harikae
>>
>
> Hi,
> From my point of view it looks good. Actual information is added,
> excessive information is removed.
> I think in the phrase:
> "add the directory where the .pc file resides to PKG_CONFIG_PATH."
> better to add wording, that PKG_CONFIG_PATH is the list of directories
> separated
> by PATH separator ( ; in Windows, : in POSIX). Otherwise the reader has
> to
> search additional information about this variable in meson
> documentation.

Hi

I think, it is better to add the other options how to configure external
libraries, if they do not have .pc file:
add meson options defined by PostgreSQL for its configuration (gettext
library example)

-Dextra_include_dirs=c:\postgres\gettext\x64-windows\include,c:\otherlibs\include
-Dextra_lib_dirs=c:\postgres\gettext\x64-windows\lib,c:\otherlibs\lib

extra_include_dirs and extra_lib_dirs are options defined by PostgreSQL.
This options are
comma separated lists of directories, if every value does not contain
comma itself.

--
Best regards,

Vladlen Popolitov.