| From: | Vladlen Popolitov <v(dot)popolitov(at)postgrespro(dot)ru> |
|---|---|
| To: | "Kohei Harikae (Fujitsu)" <harikae(dot)kohei(at)fujitsu(dot)com> |
| Cc: | 'Andres Freund' <andres(at)anarazel(dot)de>, "'pgsql-hackers(at)lists(dot)postgresql(dot)org'" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Windows meson build |
| Date: | 2024-12-27 06:57:12 |
| Message-ID: | 2fe1080dc2f42e2510b810d84eee45bd@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Kohei Harikae (Fujitsu) писал(а) 2024-12-27 04:31:
> Hi,
>
> Thank you for your advice.
> I added a sample setting PKG_CONFIG_PATH based on your advice.
>
> How do you think about this?
>
> Regards,
> Kohei Harikae
>
Hi,
From my point of view it looks good. Actual information is added,
excessive information is removed.
I think in the phrase:
"add the directory where the .pc file resides to PKG_CONFIG_PATH."
better to add wording, that PKG_CONFIG_PATH is the list of directories
separated
by PATH separator ( ; in Windows, : in POSIX). Otherwise the reader has
to
search additional information about this variable in meson
documentation.
--
Best regards,
Vladlen Popolitov.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | jian he | 2024-12-27 07:01:58 | Re: Pass ParseState as down to utility functions. |
| Previous Message | Shubham Khanna | 2024-12-27 06:36:17 | Re: Adding a '--two-phase' option to 'pg_createsubscriber' utility. |