| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> |
| Cc: | michael(dot)paquier(at)gmail(dot)com, masao(dot)fujii(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org, robertmhaas(at)gmail(dot)com |
| Subject: | Re: Wrong defeinition of pq_putmessage_noblock since 9.5 |
| Date: | 2016-07-29 17:00:50 |
| Message-ID: | 29430.1469811650@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I wrote:
> Kyotaro HORIGUCHI <horiguchi(dot)kyotaro(at)lab(dot)ntt(dot)co(dot)jp> writes:
>> Any work in this area is likely 10.0 material at this point.
> I'm not really happy with that, since refactoring it again will create
> back-patch hazards. But I see that a lot of the mess here was created
> in 9.5, which means we're probably stuck with back-patch hazards anyway.
I've pushed Kyotaro-san's original patch, which is clearly a bug fix.
I think the additional changes discussed later in this thread are
cosmetic, and probably should wait for a more general review of the
layering decisions in pqcomm.c.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nikolay Samokhvalov | 2016-07-29 18:20:12 | Re: "Strong sides of MySQL" talk from PgDay16Russia, translated |
| Previous Message | Tom Lane | 2016-07-29 16:17:43 | Re: [sqlsmith] Failed assertion in joinrels.c |