Re: [sqlsmith] Failed assertion in joinrels.c

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Jul 26, 2016 at 9:27 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> While looking at the series of functions pg_get_*, I have noticed as
>> well that pg_get_userbyid() returns "unknown (OID=%u)" when it does
>> not know a user. Perhaps we'd want to change that to NULL for
>> consistency with the rest?

> That's probably correct in theory, but it's a little less closely
> related, and I'm not entirely sure how far we want to go with this.
> Remember, the original purpose was to avoid having an internal error
> (cache lookup failed, XX000) exposed as a user-visible error message.
> Are we at risk from veering from actual bug-fixing off into useless
> tinkering? Not sure.

I'd vote for leaving that one alone; yeah, it's a bit inconsistent
now, but no one has complained about its behavior.

regards, tom lane