Re: Generate pg_stat_get_* functions with Macros

Hi,

On 12/5/22 8:44 AM, Michael Paquier wrote:
> On Mon, Dec 05, 2022 at 08:27:15AM +0100, Drouvot, Bertrand wrote:
>> On 12/4/22 6:32 PM, Nathan Bossart wrote:
>>> Alright. I marked this as ready-for-committer.
>>
>> Thanks!
>
> Well, that's kind of nice:
> 5 files changed, 139 insertions(+), 396 deletions(-)
> And I like removing code, so..
>

Thanks for looking at it!

> In the same area, I am counting a total of 21 (?) pgstat routines for
> databases that rely on pgstat_fetch_stat_dbentry() while returning an
> int64. This would lead to more cleanup.
> --

Yeah, good point, thanks!

I'll look at the "databases" ones but I think in a separate patch. The reason is that the current one is preparatory work for [1].
Means, once the current patch is committed, working on [1] and "cleaning" the databases one could be done in parallel. Sounds good to you?

[1]: https://commitfest.postgresql.org/41/3984/

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com