| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Suppress Clang 3.9 warnings |
| Date: | 2017-03-15 14:57:15 |
| Message-ID: | 2872.1489589835@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Noah Misch <noah(at)leadboat(dot)com> writes:
> On Mon, Mar 13, 2017 at 06:35:53PM +0300, Aleksander Alekseev wrote:
>> + * Unfortunately in case of strlcat and strlcpy we can't trust tests
>> + * executed by Autotools if Clang > 3.6 is used.
> This is wrong on platforms that do have strlcpy() in libc.
Didn't you submit a patch to upstream autoconf awhile ago to fix the
AC_CHECK_DECLS test for this? Seems like the correct solution is to
absorb that fix, either by updating to a newer autoconf release or by
carrying our own version of AC_CHECK_DECLS until they come out with one.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2017-03-15 15:02:52 | Re: Write Ahead Logging for Hash Indexes |
| Previous Message | Stephen Frost | 2017-03-15 14:55:06 | Re: Write Ahead Logging for Hash Indexes |