| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Aleksander Alekseev <a(dot)alekseev(at)postgrespro(dot)ru>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Suppress Clang 3.9 warnings |
| Date: | 2017-03-15 16:09:40 |
| Message-ID: | 20170315160940.GA1961015@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 15, 2017 at 10:57:15AM -0400, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > On Mon, Mar 13, 2017 at 06:35:53PM +0300, Aleksander Alekseev wrote:
> >> + * Unfortunately in case of strlcat and strlcpy we can't trust tests
> >> + * executed by Autotools if Clang > 3.6 is used.
>
> > This is wrong on platforms that do have strlcpy() in libc.
>
> Didn't you submit a patch to upstream autoconf awhile ago to fix the
> AC_CHECK_DECLS test for this?
Yes.
> Seems like the correct solution is to
> absorb that fix, either by updating to a newer autoconf release or by
> carrying our own version of AC_CHECK_DECLS until they come out with one.
As you mention upthread, that Autoconf commit is still newer than every
Autoconf release. (Last release was 58 months ago.) Altering configure.ac to
work around the bug would be reasonable, but it feels heavy relative to the
benefit of suppressing some warnings.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2017-03-15 16:21:00 | Re: new set of psql patches for loading (saving) data from (to) text, binary files |
| Previous Message | Dilip Kumar | 2017-03-15 16:05:52 | Re: Parallel Bitmap scans a bit broken |