| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Kevin Grittner <kgrittn(at)ymail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Michael Meskes <meskes(at)postgresql(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: pgindent run for 9.4 |
| Date: | 2014-05-06 22:24:47 |
| Message-ID: | 28650.1399415087@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> On Tue, May 6, 2014 at 05:35:15PM -0400, Tom Lane wrote:
>> But I don't see the reason why we shouldn't expect ecpg's headers to
>> conform to our layout rules.
> I don't know who ecpg got in there. Let me know what you would like
> done.
What I'm suggesting is that, in HEAD only, you remove these exclusion
entries:
> /ecpg/include/(sqlda|sqltypes)\.h$
> /ecpg/include/preproc/struct\.h$
then redo the pgindent run (presumably only those three files will change)
and make any necessary updates in the ecpg expected files.
Note that it's just chance that the back branch updates didn't hit those
three files already, since you said you weren't using the filter on them.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-05-07 00:09:42 | pgsql: Remove pgindent ecpg exclusion pattern |
| Previous Message | Bruce Momjian | 2014-05-06 22:19:58 | Re: [COMMITTERS] pgsql: pgindent run for 9.4 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-05-06 22:28:32 | Re: proposal: Set effective_cache_size to greater of .conf value, shared_buffers |
| Previous Message | Tom Lane | 2014-05-06 22:20:53 | Re: default opclass for jsonb (was Re: Call for GIST/GIN/SP-GIST opclass documentation) |