Re: pgsql: Widen query numbers-of-tuples-processed counters to uint64.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Widen query numbers-of-tuples-processed counters to uint64.
Date: 2016-03-13 02:58:11
Message-ID: 28339.1457837891@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Andres Freund <andres(at)anarazel(dot)de> writes:
> On March 12, 2016 1:05:46 PM PST, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Most values associated with FETCH/MOVE distances, such as PortalRun's
>> count argument and the count argument of most SPI functions that have
>> one, remain declared as "long". It's not clear whether it would be
>> worth promoting those to int64; but it would definitely be a large
>> dollop of additional API churn on top of this, and it would only help
>> 32-bit platforms which seem relatively less likely to see any benefit.

> There's also windows, where long is 32 bit, even on 64bit platforms...

I'm not personally excited about doing a lot of work, and possibly
breaking a lot (more) extensions, to provide a mostly-academic benefit
to Windows64 and little else. But, if someone else wants to tackle it
I won't stand in the way.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-03-13 03:34:55 pgsql: Fix Windows portability issue in 23a27b039d94ba35.
Previous Message Joel Jacobson 2016-03-13 02:27:20 Re: [COMMITTERS] pgsql: Provide much better wait information in pg_stat_activity.