Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state
Date: 2011-01-26 23:15:58
Message-ID: 28235.1296083758@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> On ons, 2011-01-26 at 17:47 -0500, Tom Lane wrote:
>> I was a bit disturbed by the fact that fixing only one of the four
>> variant files was enough to turn the whole buildfarm green. Are the
>> other three cases even needed anymore? If so, how can we get some
>> coverage on them?

> This is explained in plpython/expected/README. As you can see there, it
> would need some careful attention from buildfarm code and participants
> to cover all that.

Hmmm ... well, the fact that we have zero coverage on the first two
variants definitely seems surprising and scary to me. Why aren't those
getting hit by the non-C-locale buildfarm runs?

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Jan Urbański 2011-01-26 23:25:42 Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state
Previous Message Peter Eisentraut 2011-01-26 23:08:02 Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Urbański 2011-01-26 23:25:42 Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state
Previous Message Josh Berkus 2011-01-26 23:14:54 Re: Query Optimizer + Parallel Operators