Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state
Date: 2011-01-26 23:08:02
Message-ID: 1296083282.14137.8.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On ons, 2011-01-26 at 17:47 -0500, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > On lör, 2011-01-22 at 16:36 -0500, Tom Lane wrote:
> >> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> >>> Get rid of the global variable holding the error state
>
> >> The buildfarm doesn't like this patch one bit.
>
> > I have verified your adjustments and fixed up the rest.
>
> I was a bit disturbed by the fact that fixing only one of the four
> variant files was enough to turn the whole buildfarm green. Are the
> other three cases even needed anymore? If so, how can we get some
> coverage on them?

This is explained in plpython/expected/README. As you can see there, it
would need some careful attention from buildfarm code and participants
to cover all that.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2011-01-26 23:15:58 Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state
Previous Message Tom Lane 2011-01-26 22:47:10 Re: Re: [COMMITTERS] pgsql: Get rid of the global variable holding the error state

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2011-01-26 23:12:26 Re: ALTER TYPE 3: add facility to identify further no-work cases
Previous Message Tom Lane 2011-01-26 23:06:02 Re: ALTER TYPE 3: add facility to identify further no-work cases