From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com> |
Cc: | Patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: Fix mdsync never-ending loop problem |
Date: | 2007-04-05 16:15:00 |
Message-ID: | 28223.1175789700@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Heikki Linnakangas <heikki(at)enterprisedb(dot)com> writes:
> Here's a fix for the problem that on a busy system, mdsync never
> finishes. See the original problem description on hackers:
This leaks memory, no? (list_delete_cell only deletes the ListCell.)
But I dislike copying the table entries anyway, see comment on -hackers.
BTW, it's very hard to see what a patch like this is actually changing.
It might be better to submit a version that doesn't reindent the chunks
of code you aren't changing, so as to reduce the visual size of the
diff. A note to the committer to reindent the whole function is
sufficient (or if he forgets, pg_indent will fix it eventually).
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-04-05 16:19:25 | Re: Fix mdsync never-ending loop problem |
Previous Message | Heikki Linnakangas | 2007-04-05 16:14:32 | Re: Fix mdsync never-ending loop problem |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2007-04-05 16:19:25 | Re: Fix mdsync never-ending loop problem |
Previous Message | Heikki Linnakangas | 2007-04-05 16:14:32 | Re: Fix mdsync never-ending loop problem |