Re: pgsql: Refactor background psql TAP functions

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: Damir Belyalov <dam(dot)bel07(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Refactor background psql TAP functions
Date: 2023-05-16 19:43:00
Message-ID: 27BE2429-774C-46E6-8B0E-C024B83EC3B5@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 16 May 2023, at 21:04, Damir Belyalov <dam(dot)bel07(at)gmail(dot)com> wrote:

> There is another perl module: AdjustUpgrade.pm that is not in Makefile. Do we need it?

Yes, I think it should be installed too and skimming the linked thread I see no
mention of the omission being deliberate. I will take care of it.

> + $(INSTALL_DATA) $(srcdir)/PostgreSQL/Test/BackgroundPsql.pm '$(DESTDIR)$(pgxsdir)/$(subdir)/PostgreSQL/Test/AdjustUpgrade.pm'

This is wrong though, but no need to send a new version of this small thing.

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2023-05-16 21:52:00 Re: issue with meson builds on msys2
Previous Message Damir Belyalov 2023-05-16 19:04:08 Re: pgsql: Refactor background psql TAP functions