Re: pgsql: Refactor background psql TAP functions

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Damir Belyalov <dam(dot)bel07(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Refactor background psql TAP functions
Date: 2023-05-17 12:38:15
Message-ID: 0AFDFD10-178D-44FA-86A7-0909227119D5@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> On 16 May 2023, at 21:43, Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> wrote:
>
>> On 16 May 2023, at 21:04, Damir Belyalov <dam(dot)bel07(at)gmail(dot)com> wrote:
>
>> There is another perl module: AdjustUpgrade.pm that is not in Makefile. Do we need it?
>
> Yes, I think it should be installed too and skimming the linked thread I see no
> mention of the omission being deliberate. I will take care of it.

The attached is the proposed fix, which will have to be backpatched to v11 to
match the original commit. Unless there are reasons to treat this module
differently from the others wrt installation I'll go ahead and fix it in time
for beta1.

--
Daniel Gustafsson

Attachment Content-Type Size
v1-0001-Add-installation-rules-for-AdjustUpgrade-test-mod.patch application/octet-stream 2.3 KB

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tomas Vondra 2023-05-17 14:37:49 pgsql: Null-terminate the output buffer of LZ4Stream_gets
Previous Message Michael Paquier 2023-05-17 01:23:21 pgsql: Add back SQLValueFunction for SQL keywords