Re: Use of PG_VERSION

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Use of PG_VERSION
Date: 2010-01-06 22:08:27
Message-ID: 27501.1262815707@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Is there a reason tablespace.c::set_short_version() uses PG_VERSION, and
> not the simpler PG_MAJORVERSION? initdb.c::get_short_version() does the
> same thing.

Probably that code predates the addition of the separate PG_MAJORVERSION
#define. +1 for simplifying. The change I just had to make in
backend/catalog/Makefile reinforces the thought that MAJORVERSION is
what we should be using in everyplace related to this type of check.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2010-01-06 22:08:29 Re: Testing with concurrent sessions
Previous Message Dimitri Fontaine 2010-01-06 22:08:04 Re: unresolved bugs