| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use of PG_VERSION |
| Date: | 2010-01-06 23:22:57 |
| Message-ID: | 201001062322.o06NMvI28564@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Is there a reason tablespace.c::set_short_version() uses PG_VERSION, and
> > not the simpler PG_MAJORVERSION? initdb.c::get_short_version() does the
> > same thing.
>
> Probably that code predates the addition of the separate PG_MAJORVERSION
> #define. +1 for simplifying. The change I just had to make in
> backend/catalog/Makefile reinforces the thought that MAJORVERSION is
> what we should be using in everyplace related to this type of check.
Agreed. Fixed the attached, applied patch.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
| Attachment | Content-Type | Size |
|---|---|---|
| /rtmp/diff | text/x-diff | 9.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tim Bunce | 2010-01-06 23:31:31 | Re: Status of plperl inter-sp calling |
| Previous Message | Tim Bunce | 2010-01-06 23:14:05 | Re: Status of plperl inter-sp calling |