Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joshua Reich <josh(at)root(dot)net>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update
Date: 2006-07-26 03:57:45
Message-ID: 27314.1153886265@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Joshua Reich <josh(at)root(dot)net> writes:
>> The problem is that there are new functions in cube.sql, so the output
>> is now different and breaks the diff (to state the obvious).

Actually, the new theory on this is that you should explicitly create
a shell type first:

CREATE TYPE cube;

and then create the functions, and then make the type "for real".

This will still involve a change in the earthdistance expected
output (down to zero expected NOTICEs) but if we're gonna fix it
then let's fix it right.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2006-07-26 03:59:20 Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update
Previous Message Joshua Reich 2006-07-26 03:49:11 Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2006-07-26 03:59:20 Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update
Previous Message Joshua Reich 2006-07-26 03:49:11 Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-07-26 03:59:20 Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update
Previous Message Joshua Reich 2006-07-26 03:49:11 Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update