Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Joshua Reich <josh(at)root(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update
Date: 2006-07-26 03:59:20
Message-ID: 200607260359.k6Q3xKT24184@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers pgsql-patches

Tom Lane wrote:
> Joshua Reich <josh(at)root(dot)net> writes:
> >> The problem is that there are new functions in cube.sql, so the output
> >> is now different and breaks the diff (to state the obvious).
>
> Actually, the new theory on this is that you should explicitly create
> a shell type first:
>
> CREATE TYPE cube;
>
> and then create the functions, and then make the type "for real".
>
> This will still involve a change in the earthdistance expected
> output (down to zero expected NOTICEs) but if we're gonna fix it
> then let's fix it right.

OK, I will wait for the next patch. Funny I tested the cube regression
test, but not earthdistance.

--
Bruce Momjian bruce(at)momjian(dot)us
EnterpriseDB http://www.enterprisedb.com

+ If your life is a hard drive, Christ can be your backup. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tatsuo Ishii 2006-07-26 07:24:50 pgsql: New features contributed by Tomoaki Sato.
Previous Message Tom Lane 2006-07-26 03:57:45 Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update

Browse pgsql-hackers by date

  From Date Subject
Next Message ITAGAKI Takahiro 2006-07-26 05:05:08 Re: Resurrecting per-page cleaner for btree
Previous Message Tom Lane 2006-07-26 03:57:45 Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update

Browse pgsql-patches by date

  From Date Subject
Next Message ITAGAKI Takahiro 2006-07-26 05:05:08 Re: Resurrecting per-page cleaner for btree
Previous Message Tom Lane 2006-07-26 03:57:45 Re: [COMMITTERS] pgsql: /contrib/cube improvements: Update