| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Sean Chittenden <sean(at)chittenden(dot)org> |
| Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: Patch to be verbose about being unable to read ~/.pgpasss... |
| Date: | 2003-06-22 19:32:35 |
| Message-ID: | 27266.1056310355@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
Sean Chittenden <sean(at)chittenden(dot)org> writes:
> Um, I said it would change the ABI and I said as much in my previous
> post.
The ABI is only the smaller part of the problem; you'd be forcing people
to change their source code, in a rather nonobvious way.
> it is code compatible provided people aren't using any %
> escape strings in their error messages (if there aren't any format
> strings, there won't be any need to modify the program),
And if there aren't any format strings, then we don't need to change the
interface. I don't see your point at all. You cannot make use of the
added functionality without breaking client applications.
I could envision a helper procedure, known only within libpq, that has
a signature like formatNotice(PGconn* conn, const char *fmtstring, ...)
and encapsulates the work needed to handle a format string. But I see
no reason to push that work out to client applications.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Sean Chittenden | 2003-06-22 19:46:58 | Re: Patch to be verbose about being unable to read ~/.pgpasss... |
| Previous Message | Sean Chittenden | 2003-06-22 15:49:37 | Re: Patch to be verbose about being unable to read ~/.pgpasss... |