Re: [postgresql 10 beta3] unrecognized node type: 90

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: pgsql-bugs(at)postgresql(dot)org
Subject: Re: [postgresql 10 beta3] unrecognized node type: 90
Date: 2017-08-11 20:20:51
Message-ID: 27200.1502482851@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

I wrote:
> So, apparently somebody wrote ExecReScanGatherMerge, but never bothered
> to plug it into ExecReScan. From which we may draw depressing conclusions
> about how much it's been tested.

While I'm bitching ... the code coverage report at

https://coverage.postgresql.org/src/backend/executor/nodeGatherMerge.c.gcov.html

also leaves one with less than a warm feeling about the extent of test
coverage on this file. heap_compare_slots isn't invoked even once?

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Andres Freund 2017-08-11 20:26:29 Re: [postgresql 10 beta3] unrecognized node type: 90
Previous Message Tom Lane 2017-08-11 15:59:14 Re: [postgresql 10 beta3] unrecognized node type: 90

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-08-11 20:26:29 Re: [postgresql 10 beta3] unrecognized node type: 90
Previous Message Andres Freund 2017-08-11 19:50:47 Re: WIP Patch: Pgbench Serialization and deadlock errors