Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Josh Berkus <josh(at)agliodbs(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Jim Cox <shakahshakah(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, David Fetter <david(at)fetter(dot)org>
Subject: Re: [PATCH] 8.5 TODO: Add comments to output indicating version of pg_dump and of the database server
Date: 2010-02-23 18:26:29
Message-ID: 27121.1266949589@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Josh Berkus <josh(at)agliodbs(dot)com> writes:
> On 2/23/10 10:14 AM, Robert Haas wrote:
>> On Mon, Feb 22, 2010 at 8:55 PM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>>> What happened to this patch? I don't see any objections, but it was not
>>> applied.
>>
>> I think that the patch author never added it to the open CommitFest
>> and nobody else thought it was important enough to pick up. It looks
>> innocuous to me; want to go ahead and apply?

> I'd say yes. It's post-freeze, but this falls into the class of "oops,
> we forgot about this patch" which the CFs were designed to prevent.

That would be an argument for sticking this in the next CF, not for
applying it now --- it was submitted after the close of the last CF no?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stefan Kaltenbrunner 2010-02-23 18:29:27 Re: [PATCH] backend: compare word-at-a-time in bcTruelen
Previous Message Alvaro Herrera 2010-02-23 18:23:56 Re: [PATCH] backend: compare word-at-a-time in bcTruelen