Re: pgsql: Fix for globals.c- c.h must come first

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix for globals.c- c.h must come first
Date: 2018-06-19 18:22:25
Message-ID: 2690.1529432545@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

I wrote:
> It'd probably be good enough if the error detection worked with glibc's
> headers. Even if nobody noticed before a particular patch went in,
> the buildfarm would surely find it.

On second thought, we'd also need a solution for Windows, because we
have some files that only get compiled for Windows. But even two
separate tests of this sort seems reasonable.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2018-06-19 18:30:04 Re: pgsql: Fix for globals.c- c.h must come first
Previous Message Tom Lane 2018-06-19 18:19:56 Re: pgsql: Fix for globals.c- c.h must come first