Re: pgsql: Fix for globals.c- c.h must come first

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, Stephen Frost <sfrost(at)snowman(dot)net>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix for globals.c- c.h must come first
Date: 2018-06-19 21:05:43
Message-ID: 20180619210543.53hnuypnsqs2tf7t@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On 2018-06-19 14:22:25 -0400, Tom Lane wrote:
> I wrote:
> > It'd probably be good enough if the error detection worked with glibc's
> > headers. Even if nobody noticed before a particular patch went in,
> > the buildfarm would surely find it.
>
> On second thought, we'd also need a solution for Windows, because we
> have some files that only get compiled for Windows. But even two
> separate tests of this sort seems reasonable.

Could anybody working on windows (Amit, Michael?) check whether there's
an equivalent to my _FEATURES_H trick?

Greetings,

Andres Freund

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2018-06-19 23:30:55 pgsql: Clarify the README files for the various separate TAP-based test
Previous Message Bruce Momjian 2018-06-19 19:54:01 pgsql: README: add URLs for openldap installation