From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | Peter Eisentraut <peter_e(at)gmx(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Moved simple_prompt()/sprompt.c |
Date: | 2003-08-08 15:27:11 |
Message-ID: | 26722.1060356431@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Yes, thread.c, path.c, and sprompt.c should be in utils, but how do I do
> that? Utils seems to be a place things are pulled from, rather than a
> library that goes with every link.
> Is it worth creating another library that acts just like /port but is
> called utils, or should we just rename the directory to portutils?
path.c is arguably okay material for /port, since it is dealing with
platform-to-platform variations.
sprompt.c is only going to be used by stuff under src/bin. I wonder if
we should create a src/bin/utils directory.
Not sure about thread.c --- perhaps we could just dump it into libpq.
(libpq requires it anyway, no? So why not export it from there and let
the apps atop libpq use the same instance.)
> I am looking to move fmtId() over to port too so psql can use it. It is
> already used by pg_dump, and /scripts.
That's definitely not port/ material. A src/bin/utils/ directory would
make sense for it though.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2003-08-08 15:55:27 | Re: consistency check on SPI tuple count failed |
Previous Message | Tom Lane | 2003-08-08 15:21:56 | Re: Proposed macros for error fields |