Re: Add error-checking to timestamp_recv

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Add error-checking to timestamp_recv
Date: 2004-05-20 17:28:40
Message-ID: 2665.1085074120@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Stephen Frost <sfrost(at)snowman(dot)net> writes:
>> How many datatype have this issue?

> I don't think that many do.. A number of them already check incoming
> values where it's possible for them to not be valid.

In general we do check incoming binary values to ensure minimal
validity. I think when I did timestamp_recv I was thinking it was
just like int8 or float8 (respectively), in that any bit pattern is
potentially legal; I had forgotten about the range restrictions.

I haven't looked at the details of Stephen's patch (and can't till the
archives site comes back up) but the idea is probably sound.

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-05-20 18:17:51 Re: Add error-checking to timestamp_recv
Previous Message Stephen Frost 2004-05-20 17:01:55 Re: Add error-checking to timestamp_recv