Re: Add error-checking to timestamp_recv

* Bruce Momjian (pgman(at)candle(dot)pha(dot)pa(dot)us) wrote:
> Tom Lane wrote:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > I wasn't aware you could throw binary values into the timestamp fields
> > > like that. I thought you needed to use a C string for the value.
> >
> > This facility was added in 7.4 as part of the wire-protocol overhaul.
> > It's nothing directly to do with PREPARE; you could get the same result
> > with no prepared statement using PQexecParams.
>
> Ah, no wonder I had not seen that before. So, I guess the issue is how
> much error checking do we want to have for these binary values. I was a
> little disturbed to hear he could insert data he couldn't later view.
> How many datatype have this issue?

I don't think that many do.. A number of them already check incoming
values where it's possible for them to not be valid. For example,
'macaddr' accepts all possible binary values, 'inet' does error checking
on input. Binary timestamps were the only place I found in the work I
was doing where this could happen and I managed to mess up most of the
fields in one way or another before I figured it all out. :)

Stephen