Re: master make check fails on Solaris 10

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Victor Wagner <vitus(at)wagner(dot)pp(dot)ru>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: master make check fails on Solaris 10
Date: 2018-01-18 06:47:46
Message-ID: 26312.1516258066@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Victor Wagner <vitus(at)wagner(dot)pp(dot)ru> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Attached is a draft patch to incorporate Victor's slimmed-down test
>> into configure. If you have a chance, could you confirm it does
>> the right thing on your Sparc machine?

> It seems that what it does is not exactly a right thing.
> I've applied it to commit 9c7d06d60680 in master and see following
> checking for __int128 alignment bug... ok
> As far as I understand your patch, there should be:
> checking for __int128 alignment bug... broken

Yes, that's what I expected to happen.

> Then in the pg_config.h I see
> /* The normal alignment of `PG_INT128_TYPE', in bytes. */
> #define ALIGNOF_PG_INT128_TYPE 16
> /* Define to the name of a signed 128-bit integer type. */
> #define PG_INT128_TYPE __int128

That's what I'd expect if configure thinks all's well :-(

> However, make check passes.

Uh ... how could that be? If the output of configure is exactly
the same as before the patch, how could the end result be different?

> We, Marina and I would continue investigation.

I look forward to some results ... but I'm going to bed now ...

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Etsuro Fujita 2018-01-18 07:16:35 Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw
Previous Message Victor Wagner 2018-01-18 06:40:49 Re: master make check fails on Solaris 10