Re: pgsql: Suppress some "variable might be clobbered by longjmp" warnings.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Suppress some "variable might be clobbered by longjmp" warnings.
Date: 2011-03-10 05:17:03
Message-ID: 26282.1299734223@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> Suppress some "variable might be clobbered by longjmp" warnings.
>>
>> Seen with an older gcc version. I'm not sure these represent any real
>> risk factor, but still a bit scary. Anyway we have lots of other
>> volatile-marked variables in this code, so a couple more won't hurt.

> I assume you saw my comment in basebackup.c:

> * Some old compilers, e.g. gcc 2.95.3/x86, think that passing
> * a struct in the same function as a longjump might clobber
> * a variable. bjm 2011-02-04
> * http://lists.apple.com/archives/xcode-users/2003/Dec//msg00051.html

Curious that you're getting different warnings with that than I get
with HPPA 2.95.3.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Itagaki Takahiro 2011-03-10 06:24:00 pgsql: Cleanup copyright years and file names in the header comments of
Previous Message Tom Lane 2011-03-10 05:12:56 pgsql: replication/repl_gram.h needs to be cleaned too ...