| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Drop test user when done with it. |
| Date: | 2019-06-26 13:42:36 |
| Message-ID: | 26228.1561556556@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Jun 24, 2019 at 04:37:13PM +0000, Tom Lane wrote:
>> Commit d7f8d26d9 added a test case that created a user, but forgot
>> to drop it again. This is no good; for one thing, it causes repeated
>> "make installcheck" runs to fail.
> If we are on that, we still have src/test/modules/test_pg_dump/ which
> is not repeatable with multiple installchecks:
> https://www.postgresql.org/message-id/20181130163728.GE3415@tamriel.snowman.net
OK, hadn't run into that personally, but let's fix that too. Anything
that can be run with "installcheck" has to satisfy the restrictions
of being re-runnable and careful about what global names it uses.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-06-26 14:07:59 | pgsql: Add support for OpenSSL 1.1.0 and newer versions in MSVC scripts |
| Previous Message | Andrew Gierth | 2019-06-26 13:01:43 | Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.) |