Re: pgsql: Drop test user when done with it.

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Drop test user when done with it.
Date: 2019-06-26 04:21:17
Message-ID: 20190626042117.GK1714@paquier.xyz
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On Mon, Jun 24, 2019 at 04:37:13PM +0000, Tom Lane wrote:
> Drop test user when done with it.
>
> Commit d7f8d26d9 added a test case that created a user, but forgot
> to drop it again. This is no good; for one thing, it causes repeated
> "make installcheck" runs to fail.

If we are on that, we still have src/test/modules/test_pg_dump/ which
is not repeatable with multiple installchecks:
https://www.postgresql.org/message-id/20181130163728.GE3415@tamriel.snowman.net
--
Michael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Gierth 2019-06-26 06:32:29 Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Previous Message Tom Lane 2019-06-26 03:19:42 pgsql: Follow the rule that regression-test-created roles are named "re