Re: Valgrind-detected bug in partitioning code

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Valgrind-detected bug in partitioning code
Date: 2017-01-20 21:30:21
Message-ID: 26179.1484947821@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Stephen Frost <sfrost(at)snowman(dot)net> writes:
> * Tom Lane (tgl(at)sss(dot)pgh(dot)pa(dot)us) wrote:
>> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
>>> Hmm. That's bad. I kind of wonder how sane it is to think that we
>>> can invoke SQL-callable functions during a relcache reload,

>> You're doing WHAT?

> Uh. +1.

Now that I've calmed down a bit: the right way to do this sort of thing is
simply to flush the invalidated data during reload, and recompute it when
it is next requested, which necessarily will be inside a valid
transaction. Compare e.g. the handling of the lists of a relation's
indexes.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Petr Jelinek 2017-01-20 21:30:56 Re: Logical Replication WIP
Previous Message Robert Haas 2017-01-20 21:29:45 Re: Declarative partitioning - another take