Re: Shouldn't postgres_fdw report warning when it gives up getting result from foreign server?

On 2021/12/06 20:50, Bharath Rupireddy wrote:
> On Mon, Dec 6, 2021 at 1:47 PM Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> wrote:
>> Yeah, I agree that's not elegant..
>>
>> So I'd like to propose new patch with different design from
>> what I proposed before. Patch attached.
>>
>> This patch changes pgfdw_exec_cleanup_query() so that it tells
>> its callers the information about whether the timeout expired
>> or not. Then the callers (pgfdw_exec_cleanup_query and
>> pgfdw_cancel_query) report the warning messages based on
>> the results from pgfdw_exec_cleanup_query().
>
> +1 for adding a new timed_out param to pgfdw_get_cleanup_result.
> pgfdw_get_cleanup_result_v2 patch looks good to me.

Thanks for the review! I pushed the patch.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION