From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
Cc: | pgsql(at)mohawksoft(dot)com, Nicolai Tufar <ntufar(at)gmail(dot)com>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] snprintf causes regression tests to fail |
Date: | 2005-02-28 20:58:04 |
Message-ID: | 25924.1109624284@sss.pgh.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-hackers-win32 pgsql-patches |
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Ah, the problem was introduced here:
Right, it was my fault.
> The problem is that the PGAC_FUNC_PRINTF_ARG_CONTROL call was moved
> below the printf 64-bit tests. This commited patch moves
> PGAC_FUNC_PRINTF_ARG_CONTROL which is after we know AC_TRY_RUN works and
> just before printf 64-bit args are tested.
This patch breaks things in a different way: you should not have moved
the AC_LIBOBJ(snprintf) step. Also you randomly placed the arg-control
test between a chunk of code and the comment describing same.
Corrected version committed.
regards, tom lane
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-02-28 21:29:57 | Re: [HACKERS] snprintf causes regression tests to fail |
Previous Message | Bruce Momjian | 2005-02-28 20:35:18 | Re: [HACKERS] snprintf causes regression tests to fail |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-02-28 21:29:57 | Re: [HACKERS] snprintf causes regression tests to fail |
Previous Message | Bruce Momjian | 2005-02-28 20:35:18 | Re: [HACKERS] snprintf causes regression tests to fail |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2005-02-28 21:29:57 | Re: [HACKERS] snprintf causes regression tests to fail |
Previous Message | Bruce Momjian | 2005-02-28 20:35:18 | Re: [HACKERS] snprintf causes regression tests to fail |