From: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql(at)mohawksoft(dot)com, Nicolai Tufar <ntufar(at)gmail(dot)com>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] snprintf causes regression tests to fail |
Date: | 2005-02-28 21:29:57 |
Message-ID: | 200502282129.j1SLTvn24928@candle.pha.pa.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-hackers-win32 pgsql-patches |
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Ah, the problem was introduced here:
>
> Right, it was my fault.
>
> > The problem is that the PGAC_FUNC_PRINTF_ARG_CONTROL call was moved
> > below the printf 64-bit tests. This commited patch moves
> > PGAC_FUNC_PRINTF_ARG_CONTROL which is after we know AC_TRY_RUN works and
> > just before printf 64-bit args are tested.
>
> This patch breaks things in a different way: you should not have moved
> the AC_LIBOBJ(snprintf) step. Also you randomly placed the arg-control
> test between a chunk of code and the comment describing same.
Thanks.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
From | Date | Subject | |
---|---|---|---|
Next Message | Nicolai Tufar | 2005-02-28 22:40:17 | Re: [PATCHES] snprintf causes regression tests to fail |
Previous Message | Tom Lane | 2005-02-28 20:58:04 | Re: [HACKERS] snprintf causes regression tests to fail |
From | Date | Subject | |
---|---|---|---|
Next Message | Nicolai Tufar | 2005-02-28 22:40:17 | Re: [PATCHES] snprintf causes regression tests to fail |
Previous Message | Tom Lane | 2005-02-28 20:58:04 | Re: [HACKERS] snprintf causes regression tests to fail |
From | Date | Subject | |
---|---|---|---|
Next Message | Nicolai Tufar | 2005-02-28 22:40:17 | Re: [PATCHES] snprintf causes regression tests to fail |
Previous Message | Tom Lane | 2005-02-28 20:58:04 | Re: [HACKERS] snprintf causes regression tests to fail |