| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Christoph Berg <cb(at)df7cb(dot)de>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: includedir_internal headers are not self-contained |
| Date: | 2014-04-27 20:55:51 |
| Message-ID: | 25814.1398632151@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> On 2014-04-27 16:33:29 -0400, Tom Lane wrote:
>> According to the commit message, the point of that was to allow
>> pg_xlogdump to use relpath(), but I do not see it doing so;
> Well, pg_xlogdump.c itself doesn't use it, but some of the desc routines
> do. Like e.g. xact_desc_commit().
Well, that can be undone easily enough. I frankly think that printing a
file path there is more verbose and less readable than just printing the
db/ts/rel OIDs. In any case, the current situation with having
include/common referencing backend-only headers is simply broken and
unacceptable.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2014-04-27 21:05:03 | Re: So why is EXPLAIN printing only *plan* time? |
| Previous Message | David G Johnston | 2014-04-27 20:48:54 | Re: So why is EXPLAIN printing only *plan* time? |