Re: includedir_internal headers are not self-contained

On 2014-04-27 16:55:51 -0400, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > On 2014-04-27 16:33:29 -0400, Tom Lane wrote:
> >> According to the commit message, the point of that was to allow
> >> pg_xlogdump to use relpath(), but I do not see it doing so;
>
> > Well, pg_xlogdump.c itself doesn't use it, but some of the desc routines
> > do. Like e.g. xact_desc_commit().
>
> Well, that can be undone easily enough. I frankly think that printing a
> file path there is more verbose and less readable than just printing the
> db/ts/rel OIDs.

Would at least also need to include the fork name.

> In any case, the current situation with having
> include/common referencing backend-only headers is simply broken and
> unacceptable.

Agreed, I am not arguing that point. I guess the easiest fix here would
be to just move relpath.c into src/backend and ln -s it into
pg_xlogdump. Not pretty, but there's precedent.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services