Re: COPY CSV header line feature

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: COPY CSV header line feature
Date: 2005-03-16 05:22:54
Message-ID: 2545.1110950574@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl> writes:
> I think you should add the new reserved keyword to the
> unreserved_keywords list or some other.

*Every* keyword needs to be in one of those lists. I'd like to have
some sort of automatic enforcement of this, because forgetting to
add a new keyword to the right list is an everyday error.

I've been thinking that it would be good if the table in keywords.c
included an indication of the reservation category of each keyword.
So one possible approach is to do that and then somehow check that
the gram.y grammar agrees --- or even better, mechanically generate
the keyword category productions in gram.y from the keywords.c data.
Not sure just how to do that though.

Any ideas?

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Mark Kirkwood 2005-03-16 05:23:07 Re: contrib/pg_buffercache
Previous Message Alvaro Herrera 2005-03-16 03:13:16 Re: COPY CSV header line feature