Re: COPY CSV header line feature

On Tue, Mar 15, 2005 at 08:55:36PM -0600, Andrew Dunstan wrote:
> Alvaro Herrera said:
> > On Sun, Mar 13, 2005 at 06:32:20PM -0500, Andrew Dunstan wrote:
> >
> >> The attached patch implements the previously discussed header line
> >> feature for CSV mode COPY. It is triggered by the keyword HEADER
> >> (blame Bruce - he chose it ;-) ).
> >
> > I think you should add the new reserved keyword to the
> > unreserved_keywords list or some other.
>
> Please be more specific. I'll be happy to add in anything I've missed.

The Postgres grammar classifies keywords in one of several lists, in
order to make them available as names to users (column names, function
names, etc). So each time you create a new keyword and add it to the
keywords.c list, you have to add it to one of the lists on gram.y too.
See gram.y line 7669 ff.

I'd add a comment on this on gram.y:

Index: gram.y
===================================================================
RCS file: /home/alvherre/cvs/pgsql/src/backend/parser/gram.y,v
retrieving revision 2.484
diff -c -w -b -B -c -r2.484 gram.y
*** gram.y 14 Mar 2005 00:19:36 -0000 2.484
--- gram.y 16 Mar 2005 03:12:48 -0000
***************
*** 327,333 ****
/*
* If you make any token changes, update the keyword table in
* parser/keywords.c and add new keywords to the appropriate one of
! * the reserved-or-not-so-reserved keyword lists, below.
*/

/* ordinary key words in alphabetical order */
--- 327,334 ----
/*
* If you make any token changes, update the keyword table in
* parser/keywords.c and add new keywords to the appropriate one of
! * the reserved-or-not-so-reserved keyword lists, below; search this
! * file for "Name classification hierarchy."
*/

/* ordinary key words in alphabetical order */

--
Alvaro Herrera (<alvherre[(at)]dcc(dot)uchile(dot)cl>)
Tulio: oh, para qué servirá este boton, Juan Carlos?
Policarpo: No, aléjense, no toquen la consola!
Juan Carlos: Lo apretaré una y otra vez.