| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | pgsql-hackers(at)postgreSQL(dot)org |
| Subject: | Another pgindent gripe |
| Date: | 2014-02-13 23:14:17 |
| Message-ID: | 25441.1392333257@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
I noticed that current pgindent wants to do this to a recently-added
comment in psql/copy.c:
*************** handleCopyIn(PGconn *conn, FILE *copystr
*** 627,633 ****
/*
* This code erroneously assumes '\.' on a line alone
* inside a quoted CSV string terminates the \copy.
! * http://www.postgresql.org/message-id/E1TdNVQ-0001ju-GO@wrigleys.postgresql.org
*/
if (strcmp(buf, "\\.\n") == 0 ||
strcmp(buf, "\\.\r\n") == 0)
--- 627,634 ----
/*
* This code erroneously assumes '\.' on a line alone
* inside a quoted CSV string terminates the \copy.
! * http://www.postgresql.org/message-id/E1TdNVQ-0001ju-GO@w
! * rigleys.postgresql.org
*/
if (strcmp(buf, "\\.\n") == 0 ||
strcmp(buf, "\\.\r\n") == 0)
Doesn't seem particularly friendly.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-02-13 23:21:03 | Re: Another pgindent gripe |
| Previous Message | Andres Freund | 2014-02-13 23:06:34 | Re: issue with gininsert under very high load |