Re: Another pgindent gripe

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Another pgindent gripe
Date: 2014-02-13 23:21:03
Message-ID: 20140213232103.GJ32126@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Feb 13, 2014 at 06:14:17PM -0500, Tom Lane wrote:
> I noticed that current pgindent wants to do this to a recently-added
> comment in psql/copy.c:
>
> *************** handleCopyIn(PGconn *conn, FILE *copystr
> *** 627,633 ****
> /*
> * This code erroneously assumes '\.' on a line alone
> * inside a quoted CSV string terminates the \copy.
> ! * http://www.postgresql.org/message-id/E1TdNVQ-0001ju-GO@wrigleys.postgresql.org
> */
> if (strcmp(buf, "\\.\n") == 0 ||
> strcmp(buf, "\\.\r\n") == 0)
> --- 627,634 ----
> /*
> * This code erroneously assumes '\.' on a line alone
> * inside a quoted CSV string terminates the \copy.
> ! * http://www.postgresql.org/message-id/E1TdNVQ-0001ju-GO@w
> ! * rigleys.postgresql.org
> */
> if (strcmp(buf, "\\.\n") == 0 ||
> strcmp(buf, "\\.\r\n") == 0)
>
> Doesn't seem particularly friendly.

Yeah, that is ugly, and I was about to add a URL to a C comment myself
today.

I can set the column target width, but there doesn't seem to be any flag
that says to avoid breaking text to do the wrapping.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2014-02-13 23:49:21 Re: issue with gininsert under very high load
Previous Message Tom Lane 2014-02-13 23:14:17 Another pgindent gripe