| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Erik Rijkers" <er(at)xs4all(dot)nl> |
| Cc: | "Alvaro Herrera" <alvherre(at)2ndquadrant(dot)com>, pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Create libpgcommon, and move pg_malloc et al to it |
| Date: | 2013-02-12 18:27:21 |
| Message-ID: | 25323.1360693641@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
"Erik Rijkers" <er(at)xs4all(dot)nl> writes:
> On Tue, February 12, 2013 17:19, Alvaro Herrera wrote:
>> I'm not sure are you suggesting, though. Are you saying that the commit
>> message should explicitely state "this patch requires initdb" or some
>> such?
> I was under the impression that this was habitually done in commit messages, but looking back
> through the commitlog messages it's not all that clear although sometimes catversion bumps are
> explicitly mentioned.
I think usually if the topic is mentioned in a commit message, it's to
explain why we are (or are not) forcing an initdb. By and large, if a
patch touches catversion.h, that ought to be sufficient warning ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Heikki Linnakangas | 2013-02-13 15:53:05 | pgsql: Update visibility map in the second phase of vacuum. |
| Previous Message | Erik Rijkers | 2013-02-12 16:45:59 | Re: pgsql: Create libpgcommon, and move pg_malloc et al to it |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Boszormenyi Zoltan | 2013-02-12 18:32:48 | Re: Strange Windows problem, lock_timeout test request |
| Previous Message | Josh Berkus | 2013-02-12 18:03:27 | Re: Re: Proposal for Allow postgresql.conf values to be changed via SQL [review] |