Re: pgsql: Harden new test case against force_parallel_mode = regress.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pgsql: Harden new test case against force_parallel_mode = regress.
Date: 2023-03-03 18:03:31
Message-ID: 2506573.1677866611@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Fri, Mar 3, 2023 at 12:46 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Couldn't we install the leader's snapshot into both transactions?

> Yeah, maybe that would Just Work. Not sure.

Well, IIUC the worker is currently getting a brand new snapshot
for its startup transaction, which is exactly what you said upthread
it should never do. Seems like that could have more failure modes
than just this one.

regards, tom lane

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2023-03-04 17:12:03 pgsql: Tighten header pre-inclusions in headerscheck and cpluspluscheck
Previous Message Robert Haas 2023-03-03 17:56:23 Re: pgsql: Harden new test case against force_parallel_mode = regress.

Browse pgsql-hackers by date

  From Date Subject
Next Message Jeroen Vermeulen 2023-03-03 18:25:48 Re: libpq: PQgetCopyData() and allocation overhead
Previous Message Robert Haas 2023-03-03 17:56:23 Re: pgsql: Harden new test case against force_parallel_mode = regress.