Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: Amul Sul <sulamul(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro
Date: 2023-11-14 15:59:04
Message-ID: 2489946.1699977544@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> On Tue, Nov 14, 2023 at 04:25:24PM +0530, Amul Sul wrote:
>> Changes looks pretty much straight forward, but patch failed to apply on the
>> latest master head(b41b1a7f490) at me.

> Thanks for taking a look. Would you mind sharing the error(s) you are
> seeing? The patch applies fine on cfbot and my machine, and check-world
> continues to pass.

It may be a question of the tool used to apply the patch. IME,
"patch" is pretty forgiving, "git am" very much less so.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2023-11-14 16:03:18 Re: should check collations when creating partitioned index
Previous Message Nathan Bossart 2023-11-14 15:51:05 Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro