Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Amul Sul <sulamul(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: retire MemoryContextResetAndDeleteChildren backwards compatibility macro
Date: 2023-11-14 16:05:53
Message-ID: 20231114160553.GA2062099@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Nov 14, 2023 at 10:59:04AM -0500, Tom Lane wrote:
> Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
>> On Tue, Nov 14, 2023 at 04:25:24PM +0530, Amul Sul wrote:
>>> Changes looks pretty much straight forward, but patch failed to apply on the
>>> latest master head(b41b1a7f490) at me.
>
>> Thanks for taking a look. Would you mind sharing the error(s) you are
>> seeing? The patch applies fine on cfbot and my machine, and check-world
>> continues to pass.
>
> It may be a question of the tool used to apply the patch. IME,
> "patch" is pretty forgiving, "git am" very much less so.

Ah. I just did a 'git diff > file_name' for this one, so you'd indeed need
to use git-apply instead of git-am. (I ordinarily use git-format-patch,
but I sometimes use git-diff for trivial or prototype patches.)

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2023-11-14 16:15:10 Re: should check collations when creating partitioned index
Previous Message Peter Eisentraut 2023-11-14 16:05:35 Re: Why do indexes and sorts use the database collation?